Skip to content

Fix subcaption Type Mismatch #3315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2023
Merged

Fix subcaption Type Mismatch #3315

merged 2 commits into from
Aug 6, 2023

Conversation

@MrDiver
Copy link
Collaborator

@MrDiver MrDiver commented Aug 6, 2023

closes #3243

@MrDiver MrDiver added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Aug 6, 2023
@MrDiver MrDiver self-assigned this Aug 6, 2023
@MrDiver MrDiver requested a review from behackl August 6, 2023 08:55
@MrDiver MrDiver changed the title Fix random complaint about list Fix subcaption Type Mismatch Aug 6, 2023
behackl
behackl approved these changes Aug 6, 2023
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@behackl behackl merged commit 9561896 into ManimCommunity:main Aug 6, 2023
@behackl behackl added this to the v0.18.0 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behackl behackl behackl approved these changes

Assignees

@MrDiver MrDiver

Labels

pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Projects

Dev Board
Status: ✅ Done

Milestone

v0.18.0

Development

Successfully merging this pull request may close these issues.

Throw an exception when using Scene.add_subcaption

2 participants

@MrDiver @behackl